Skip to content

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jan 14, 2023

Issue #, if available

Description of changes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner January 14, 2023 00:04
@GavinZZ GavinZZ changed the title Adding more type hints chore: Adding more type hints Jan 14, 2023
Copy link
Contributor

@ssenchenko ssenchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we're adding too much Any just to get rid of #type: ignore. I don't think it's what we should do. Some of those Any at least should be some Container[Any].
I made a couple of comments and there are more cases like that below.

@GavinZZ GavinZZ merged commit af76a9e into aws:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants