Skip to content

Conversation

@jodion
Copy link

@jodion jodion commented Feb 19, 2019

Issue #, if available:
KMS isn't used in this code, but the template.yaml file references it.
Description of changes:
Removed KeyIdParameter as it's not used in the function.
Removed Policy pointing to the KeyIdParameter as it's not used in the function.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #818 into develop will decrease coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #818      +/-   ##
===========================================
- Coverage    94.85%   94.32%   -0.53%     
===========================================
  Files           67       67              
  Lines         2952     2626     -326     
  Branches       576      464     -112     
===========================================
- Hits          2800     2477     -323     
- Misses          76       78       +2     
+ Partials        76       71       -5
Impacted Files Coverage Δ
...lator/plugins/application/serverless_app_plugin.py 80.15% <100%> (ø) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️
samtranslator/model/eventsources/push.py 86.59% <0%> (-3.71%) ⬇️
samtranslator/model/api/api_generator.py 95.9% <0%> (-2.15%) ⬇️
samtranslator/model/sam_resources.py 96.01% <0%> (-0.97%) ⬇️
samtranslator/model/intrinsics.py 95% <0%> (-0.46%) ⬇️
samtranslator/swagger/swagger.py 97.84% <0%> (-0.09%) ⬇️
samtranslator/model/eventsources/pull.py 91.48% <0%> (-0.04%) ⬇️
...amtranslator/policy_template_processor/template.py 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651550c...149a2ee. Read the comment docs.

@brettstack
Copy link
Contributor

Thanks for cleaning this up!

@brettstack brettstack changed the base branch from master to develop February 19, 2019 18:21
@brettstack
Copy link
Contributor

Could you rebase your changes onto develop branch? Alternatively, close this PR and submit a new one directly to develop.

@timoschilling
Copy link
Contributor

This PR can be close since the changed file has been removed in #1341.

@praneetap praneetap closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants