Skip to content

Implement HttpServletRequest.getRequestURL() #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 20, 2017
Merged

Implement HttpServletRequest.getRequestURL() #11

merged 9 commits into from
Feb 20, 2017

Conversation

@mattcorey
Copy link
Contributor

@mattcorey mattcorey commented Feb 19, 2017

Implementing getRequestURL() on the HttpServletRequest object addresses #10. In the process, I also adjusted the following methods, which all contribute to getRequestURL()

  • getServerName()
  • getServer/LocalPort()
  • getContextPath()

Tests added and AwsProxyRequestBuilder adjusted

@sapessi sapessi merged commit 6fd1475 into aws:master Feb 20, 2017
@sapessi
Copy link
Contributor

sapessi commented Feb 20, 2017

Thanks Matt, merged the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattcorey @sapessi