Provide first module to run Struts2 based applications as AWS Lambda … #159
Conversation
sapessi
left a comment
sapessi
left a comment
There was a problem hiding this comment.
Some comments and minor nit-picky issues. I'll hold this here until the 1.1.1 is out and I'm ready to merge with 1.2-SNAPSHOT.
| <groupId>org.apache.struts</groupId> | ||
| <artifactId>struts2-core</artifactId> | ||
| <version>${struts2.version}</version> | ||
| <optional>true</optional> |
There was a problem hiding this comment.
Is this optional because you expect developers to pick their own version of Struts2? If we want to enable this, we should make sure that this can support most versions of struts 2.
There was a problem hiding this comment.
You are right struts2-core should be required when this lib is used. I changed this.
...ainer-struts2/src/main/java/com/amazonaws/serverless/proxy/struts2/Struts2LambdaHandler.java
Show resolved
Hide resolved
|
No rush on docs + archetype, 1.2 is likely going out in a few weeks. It's not necessary for publication, but when you get a chance it would be good to include a pet store sample in this repo like we have for the other frameworks. |
…s based on Struts2 aws#149
|
Hi @sapessi, For a quick start I added a initial WIKI page for instructions and references in the README. https://github.com/awslabs/aws-serverless-java-container/wiki/Quick-start-Struts |
|
Hi @sapessi, I created a pet store example similar to the other frameworks. I hope this is already a goof starting point for struts2 based lambdas. Best Regards Johannes |
|
I've merged this into the core branch where I'm working on the next release. Closing the pull request. |
2 participants
Provide first module to run Struts2 based applications as AWS Lambda functions
#149