Solves issue #188 setting the wrong HTTP header. #189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also solves Maven relativePath problem using a clean build env
larmog
force-pushed
the
fix_character_encoding
branch
from
bedf8e6 to
87b83a1
Compare
Contributor
|
Thanks for the PR. Don't know how I ended up missing this, apologies for the delay. I will merge #186 first so that we don't have to change the relative path of dependencies. |
sapessi
added a commit
that referenced
this pull request
Oct 19, 2018
Contributor
|
Merged into the core branch where I'm working on the next release. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem in #188 where the wrong HTTP header was used.