Skip to content

Form param handling fixes #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2022
Merged

Form param handling fixes #446

merged 3 commits into from
Jan 10, 2022

Conversation

@deki
Copy link
Contributor

@deki deki commented Jan 3, 2022

Issue #, if available:
#340

Description of changes:

  • Empty form params are now available as part of the request object.
  • Form param names are now included in getParameterNames()

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@deki deki force-pushed the 340-emptyFormParams branch from 50eed23 to 0288c48 Compare January 7, 2022 09:58
@deki deki requested a review from sapessi January 7, 2022 10:02
sapessi
sapessi approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@sapessi sapessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@deki deki merged commit 58cfb52 into aws:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sapessi sapessi sapessi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deki @sapessi