Fix NPE for null in the query parameters #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapessi
reviewed
Feb 2, 2017
| public Enumeration<String> getParameterNames() { | ||
| List<String> paramNames = new ArrayList<>(); | ||
| paramNames.addAll(request.getQueryStringParameters().keySet()); | ||
| Map<String, String> queryStringParameters = request.getQueryStringParameters(); |
Contributor
There was a problem hiding this comment.
Could we reduce this to:
if (request.getQueryStringParameters() != null) {
paramsNames.addAll(request.getQueryStringParameters().keySet());
}
sapessi
reviewed
Feb 2, 2017
|
|
||
| private String getQueryStringParameterCaseInsensitive(String key) { | ||
| if (request.getQueryStringParameters() == null) { | ||
| Map<String, String> queryStringParameters = request.getQueryStringParameters(); |
Contributor
There was a problem hiding this comment.
Do we need to assign here? Wouldn't this method have worked before?
sapessi
suggested changes
Feb 2, 2017
Contributor
sapessi
left a comment
sapessi
left a comment
There was a problem hiding this comment.
Left a couple of comments. I'd like to try and avoid assignments unless necessary.
Contributor
|
Thanks for the pull request, bugs slipped through the cracks. Left just a couple of comments in the commit. |
… to comments in PR
Contributor
Author
|
@sapessi I've changed the code according to your comments. |
sapessi
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to use the Spring EchoApp in the real AWS Lambda and the
/echo/query-stringGET-request was failed for non-set query parameters. It happened because in this caseAwsProxyRequest.queryStringParametersremains uninitialized.