- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.8k
 
Changes ported from https://github.com/awsdocs/aws-doc-sdk-examples/p… #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ull/1029/files (so the changes fit into the new structure to code samples was implementement)
              
                    beckandros
  
              
              reviewed
              
                  
                    Jun 30, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edits for descriptions, comment strings.
        
          
                javascript/example_code_v3/lambda/tutorial/slotassets/ddb-table-create.js
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/ddb-table-populate.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/ddb-table-populate.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/ddb-table-populate.js
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/lambda-function-setup.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/lambda-function-setup.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/lambda-function-setup.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/lambda-role-setup.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/s3-bucket-setup-non-modular.js
          
            Show resolved
            Hide resolved
        
              
          
                javascript/example_code_v3/lambda/tutorial/slotassets/s3-bucket-setup.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           ready to merge.  | 
    
  This was referenced Nov 5, 2022 
      
  This was referenced Dec 25, 2022 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Copied from #1029 (described below)
(also did clean up of code and added tests)
#1029 PR description:
As below are all the changes to the Lambda example:
Add flattened zip folder in to the repo, making it easier to contribute.
Update all the scripts, front-end code and back-end lambda function code into V3 flavor
Use webpack for frontend SDK code because V3 no longer provide browser SDK from CDN
Use webpack for bundling Lambda function because lambda native runtime doesn't provide modularized V3 SDK like V2 does. This means you cannot just type const AWS = require('aws-sdk') to import the SDK
TODO Other than these change, the paired doc needs to be updated as well.
The original repo only comes with a .zip archive which makes it very hard to show the code change.
So I deflated the archive in first commit. So if you see the second commit(d2af238), it contains all the code change migrating from V2 to V3
The submitter has added the default copyright notice to all files.
The submitter has added unit tests for all code paths, run all of them, and they all pass.
The submitter has run a linter on the code, and all of the submitter's team's minimum rules pass.
The submitter has added the team's minimum usage documentation to the code.
The submitter has had their Editor edit all comments and strings, and the submitter has incorporated any and all resulting edits.
The submitter has added all of the submitter's team's related API reporting metadata.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.