chore(ci): use new pypi trusted publisher for increase security#2198
Merged
heitorlessa merged 7 commits intoaws-powertools:developfrom May 3, 2023
Merged
Conversation
boring-cyborg
bot
added
the
github-actions
pull-request-size
bot
added
the
size/M
Contributor
Author
|
cc @rubenfonseca @leandrodamascena - just pending docs but please let me know if you've got any questions. |
Contributor
|
Looking at it now. |
rubenfonseca
suggested changes
May 3, 2023
Contributor
rubenfonseca
left a comment
rubenfonseca
left a comment
There was a problem hiding this comment.
Some small things, but amazing job!
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Co-authored-by: Ruben Fonseca <fonseka@gmail.com> Signed-off-by: Heitor Lessa <lessa@amazon.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #2185
Summary
Updates our release to use new PyPi Trusted Publisher to exchange GHA OIDC token for a valid PyPi token for publishing.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.