feat(user-agent): add custom header User-Agent to AWS SDK requests#2267
feat(user-agent): add custom header User-Agent to AWS SDK requests#2267leandrodamascena merged 28 commits intoaws-powertools:developfrom
Conversation
- Need to review on how to import botocore - Review how to get PT version - better solution than implementing in __init__.py ?
- rename module to `user_agent` - add feature name "parameters", "idempotency" to user-agent
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
- rename module to `user_agent` - add feature name "parameters", "idempotency" to user-agent
- rename module to `user_agent` - add feature name "parameters", "idempotency" to user-agent
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2267 +/- ##
===========================================
- Coverage 97.47% 97.21% -0.26%
===========================================
Files 150 152 +2
Lines 6925 6998 +73
Branches 509 513 +4
===========================================
+ Hits 6750 6803 +53
- Misses 137 155 +18
- Partials 38 40 +2
☔ View full report in Codecov by Sentry. |
|
Hi @heitorlessa! After some hard work and efforts put into research, PoC, and exhaustive tests done by Roger and me, I think we need one last review from you on this PR before the merge. |
heitorlessa
left a comment
There was a problem hiding this comment.
looks great! Some initial comments to make reading code and refactoring later easier.
I'll look on doc strings and for ergonomics when I have more time during the flight.
Just missing this additional area for user-agent:
aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py
Outdated
Show resolved
Hide resolved
|
Hey Heitor, Thanks! |
Thank you for indicating this area @heitorlessa! I Didn't remember we made life easier to get objects from S3 when using CodePipelineJob :) |
leandrodamascena
left a comment
There was a problem hiding this comment.
Hello @roger-zhangg! This is a huge amount of great work! Thanks for all efforts and research to make it possible.
APPROVED!
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
…ws-powertools#2267) Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
…2267) Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
Issue number: #2284
Summary
Implement standard user-agent in Powertools
Changes
idempotencyandparametersfeatureUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
**RFC issue number**:Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.