Conversation
Collaborator
kyakuno
reviewed
Mar 23, 2023
audio_processing/vggish/vggish.py
Outdated
| else: | ||
| wav_data = librosa.load(input_path, sr=SAMPLE_RATE)[0] | ||
|
|
||
| samples = wav_data / 32768.0 # Convert to [-1.0, +1.0] |
Collaborator
There was a problem hiding this comment.
librosaの段階で-1.0 - +1.0に正規化されているのを、さらに/32768.0で小さくしているように見えます。
| savepath = get_savepath(args.savepath, input_path) | ||
| logger.info(f'saved at : {savepath}') | ||
|
|
||
| np.save(savepath, result) |
Collaborator
There was a problem hiding this comment.
torchで計算したfeatureをnumpyで保存しておいて、誤差をprintしていただければと思います。
Collaborator
|
@yuki399 こちらも対応検討、お願いします。 |
Author
|
指摘に関して修正しました |
# Conflicts: # README.md # scripts/download_all_models.sh
Collaborator
|
入力の時間方向がStatic Shapeで19に固定されているので、音声の長さが19でない場合にReshapeでエラーになる。
|
Collaborator
|
@yuki399 入力のバッチサイズをDynamicShapeでエクスポートして、音声の長さが異なる場合も処理可能にできますでしょうか？ |
Collaborator
|
また、--inputに複数のファイルを与えた場合に、それぞれのファイルでEmbeddingを計算し、ファイル同士の距離をprintできればと思います。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1057