Skip to content

Conversation

@kthyng
Copy link
Member

@kthyng kthyng commented Jan 23, 2023

Pull Request Reminders

  • Make sure the notebooks in the docs directory all run.
  • Add tests for the new functionality.
  • Add a bullet to docs/whats_new.rst describing your new work. If not already present, add a new section at the top of the document stating "[expected new version number] (unreleased)", for example: "v0.7.3 (unreleased)"

This PR gets distances from xoak without the new changes there since they aren't available in a version yet. This also updates the docs here so they are run with myst-nb.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #88 (82a30f2) into main (8061733) will decrease coverage by 0.06%.
The diff coverage is 79.59%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   92.79%   92.74%   -0.06%     
==========================================
  Files          19       19              
  Lines        1513     1529      +16     
==========================================
+ Hits         1404     1418      +14     
- Misses        109      111       +2     
Flag Coverage Δ
unittests 92.74% <79.59%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
extract_model/utils.py 82.35% <11.11%> (-0.26%) ⬇️
extract_model/extract_model.py 77.51% <90.47%> (+1.19%) ⬆️
extract_model/accessor.py 93.33% <100.00%> (+0.09%) ⬆️
extract_model/grids/triangular_mesh.py 99.31% <100.00%> (ø)
tests/test_accessor.py 92.30% <100.00%> (ø)
tests/test_em.py 98.80% <100.00%> (+0.59%) ⬆️
tests/test_sel2d.py 98.46% <100.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kthyng kthyng merged commit e13351e into axiom-data-science:main Jan 23, 2023
@kthyng kthyng deleted the old_xoak branch January 23, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant