BUGFIX 'silverstripe/staticpublishqueue' user agent should be ignored #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't generally like to include package-specific work-arounds, however this seems like the best solution here. Thanks for your input @mattclegg - I'll push through a new release shortly. |
Contributor
Author
|
Yeah, I agree that it's not good to use a package-specific work-around. I've updated it to use a more generic approach; #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
silverstripe/silverstripe-staticpublishqueuemodule theREQUEST_URIis updated so what's used for the request will be different from what is defined in$_SERVER['REQUEST_URI'].As the
REQUEST_URIcan no longer be relied on then it makes more sense to ignore the user agent for staticpublishqueue.ref; https://github.com/silverstripe/silverstripe-staticpublishqueue/blob/master/src/Publisher.php#L82-L101