Use std::string_view instead const std::string& since we update codebase to c++17

[halx99]

[wzhengsen]

Now that the c++ standard has been upgraded to c++17 is there any consideration of using the standard library to implement FileUtils?
This would greatly reduce code variability across platforms.

[aismann]

Some more hints where you can replace pre-C++17 string parameter with std::string_view:
https://riptutorial.com/cplusplus/example/6571/using-the-std--string-view-class

[halx99]

Now that the c++ standard has been upgraded to c++17 is there any consideration of using the standard library to implement FileUtils? This would greatly reduce code variability across platforms.

I'm not sure does it worth to replace exists FileUtils implementation with c++17 filesystem APIs

[halx99]

Some more hints where you can replace pre-C++17 string parameter with std::string_view: https://riptutorial.com/cplusplus/example/6571/using-the-std--string-view-class

Good point

[aismann]

A search construct can find all this "parameter constructs" to help to to replace it with 'string_view'

[halx99]

That's a little crazzy, but may be workable with regex search

[halx99]

@aismann Do you have interesting to post a PR work for this?

[halx99]

Some hints:

• Should skip all thirdparty
• Should skip some extensions: fairygui, DragonBones, spine
• Does the return type const std::string& also need replace with std::string_view?

[aismann]

@aismann Do you have interesting to post a PR work for this?

At the moment I have to work on real world stuff.
Maybe 2022 or some PR snippet step by step

[aismann]

Here a first check and counting:

Starting with "templates' and 'tests' is a good first step.