-
Notifications
You must be signed in to change notification settings - Fork 19
Fix/object hash #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/object hash #266
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 97.97% 97.99% +0.01%
==========================================
Files 41 41
Lines 8640 8722 +82
==========================================
+ Hits 8465 8547 +82
Misses 175 175
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ccamel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks 👍
bdeneux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Fix a critical issue regarding the computation of
Objecthash, this is used as index keys to avoid persisting many times the object part of triples.Issue details
In the case of a named node
Object, the value part of the node wasn't taken into account in the hash computation, which results in considering equal two differentObjectshaving the same namespace.