Skip to content

Conversation

@amimart
Copy link
Contributor

@amimart amimart commented Jun 23, 2023

Description

Fix a critical issue regarding the computation of Object hash, this is used as index keys to avoid persisting many times the object part of triples.

Issue details

In the case of a named node Object, the value part of the node wasn't taken into account in the hash computation, which results in considering equal two different Objects having the same namespace.

@amimart amimart self-assigned this Jun 23, 2023
@bot-anik
Copy link
Member

bot-anik commented Jun 23, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 402.55 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 650.74 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 769.3 KB (-0.01% 🔽)

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #266 (98cef6c) into main (3d95467) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   97.97%   97.99%   +0.01%     
==========================================
  Files          41       41              
  Lines        8640     8722      +82     
==========================================
+ Hits         8465     8547      +82     
  Misses        175      175              
Impacted Files Coverage Δ
contracts/okp4-cognitarium/src/contract.rs 99.34% <100.00%> (-0.02%) ⬇️
contracts/okp4-cognitarium/src/querier/engine.rs 97.80% <100.00%> (ø)
contracts/okp4-cognitarium/src/state/triples.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks 👍

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@amimart amimart merged commit 938860e into main Jun 23, 2023
@amimart amimart deleted the fix/object-hash branch June 23, 2023 13:01
@bot-anik
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants