Repository navigation
[Discussion] Playerbot core branch reverts official API signatures (e.g., CombatStop) — how to solve this architectural conflict? #28268
mayalgithub
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Background:
I am trying to integrate the latest official AzerothCore (with microservices / async DB), NPCBots, and Playerbot into one unified server.
The Issue:
When diffing the official master branch with the mod-playerbots/azerothcore-wotlk (Playerbot branch), I noticed that the Playerbot core branch reverts several official API signatures instead of adapting the module code.
For example, in src/server/game/Entities/Unit/Unit.h:
Official Core: void CombatStop(bool includingCast = false, bool mutualPvP = true, bool keepPvPForOthers = false);
Playerbot Core: void CombatStop(bool includingCast = false, bool mutualPvP = true);
It also reverts ModuleDatabasePool (async DB back to sync) and other new features.
Why this is a problem:
This completely breaks NPCBots (which relies on keepPvPForOthers) and makes it impossible to use Playerbot alongside the latest official core features.
My Question:
Since the Playerbot repo does not accept Issues, I'm asking here:
Is there a recommended way to integrate Playerbot with the latest core without reverting these signatures?
Has anyone successfully adapted Playerbot to the latest keepPvPForOthers and async DB architecture?
Should I manually patch the mod-playerbots module to adapt to the new signatures?
All reactions