Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goblin and Gnomish engineering accessible at same time #5390

Closed
4 of 11 tasks
ghost opened this issue Apr 21, 2021 · 7 comments · Fixed by #9490
Closed
4 of 11 tasks

Goblin and Gnomish engineering accessible at same time #5390

ghost opened this issue Apr 21, 2021 · 7 comments · Fixed by #9490
Labels
ChromieCraft Generic No specific levelrange Confirmed Profession Issues related to professions

Comments

@ghost
Copy link

ghost commented Apr 21, 2021 •
edited by Yehonal
Loading

Originally reported chromiecraft/chromiecraft#443

WHAT CLIENT DO YOU PLAY ON?

  • enGB
  • enUS
  • other (specify)
FACTION
  • Alliance
  • Horde
CONTENT PHASE:
  • Generic
  • 1-19
  • 20-29
  • 30-39
  • 40-49
  • 50-59
CURRENT BEHAVIOUR:

As an engineering 225 you can learn both Goblin and Gnomish engineering at the same .

EXPECTED BLIZZLIKE BEHAVIOUR:

Only one engineering option should be train-able at the time. having both goblin and gnomish engineering should not be possible.

https://wowpedia.fandom.com/wiki/Gnome_Engineering?oldid=2299320
https://wowpedia.fandom.com/wiki/Goblin_Engineering

From patch 3.2.0 until Cataclysm, Gnomish Engineers and Goblin Engineers could switch profession specializations for 150g by visiting Narain Soothfancy's hut in northeast Tanaris and interacting with the book on the table.

STEPS TO REPRODUCE THE PROBLEM:
  1. Level a char to 20+ and a minimum of 205 engineering.
  2. .go c 387 - this gets you to Oglethorpe Obnoticus in Booty Bay, who is the gnomish eng trainer. Learn all his recipes.
  3. .go c 23414 - this takes you to Nixx Sprocketspring, goblin eng trainer in Gadgetzan. He will also teach you all goblin recipes without any pre-req quests done
  4. Now you have access to both sets:
    WoWScrnShot_041921_212305
EXTRA NOTES:

Thanks for reproduction steps and extended discussion to @Azcobu and @necropola

AC HASH/COMMIT:

chromiecraft@b9ae587

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@Azcobu Azcobu mentioned this issue Apr 22, 2021
Closed
@FrancescoBorzi
Copy link
Contributor

might be worth checking this comment: chromiecraft/chromiecraft#443 (comment)

@Kitzunu
Copy link
Member

Kitzunu commented Apr 28, 2021

This will be fixed when trainer port is done

@Kitzunu Kitzunu linked a pull request Apr 28, 2021 that will close this issue
refactor(Core/Trainer): Import TC handling of Trainers #5428
Closed
1 task
@FrancescoBorzi
Copy link
Contributor

@Kitzunu have you checked that comment?

@Kitzunu
Copy link
Member

Kitzunu commented Apr 28, 2021

Yes

@T1ti
Copy link
Contributor

T1ti commented Apr 28, 2021 •
edited
Loading

It's an issue with missing data in column "spell trainer" of creature_template

Litterally only armor smith and weaponsmith have data in this column right now

I bet leather working has the same issue.

@FrancescoBorzi
Copy link
Contributor

@Kitzunu are you still planning to fix this?

@Kitzunu
Copy link
Member

Kitzunu commented May 26, 2021

I am still working on the PR to refactor it. About down to 500 errors now.

But last two weeks before graduation so I need to lay focus elsewhere

@Kitzunu Kitzunu mentioned this issue May 29, 2021
Open
@ghost ghost removed the ChromieCraft Generic label Oct 5, 2021
@Azcobu Azcobu added ChromieCraft Generic No specific levelrange Confirmed labels Oct 6, 2021
@syssneck syssneck added Profession Issues related to professions Priority-Medium labels Oct 6, 2021
@Azcobu Azcobu mentioned this issue Nov 29, 2021
Closed
8 tasks
UltraNix added a commit to UltraNix/azerothcore-wotlk that referenced this issue Dec 4, 2021
@UltraNix
fix(Core/Trainers): Added new column ReqSpell to npc_trainer table.
4017d7f 
Prevent learning gnomish and goblin engineering recipes at same time.
Fixes azerothcore#5390
@UltraNix UltraNix mentioned this issue Dec 4, 2021
Merged
FrancescoBorzi pushed a commit that referenced this issue Dec 16, 2021
@UltraNix @Nyeriah
fix(Core/Trainers): add new column ReqSpell to npc_trainer table (#…
0f83d52 
…9490)

Prevent learning gnomish and goblin engineering recipes at same time.
Fixes #5390

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChromieCraft Generic No specific levelrange Confirmed Profession Issues related to professions
Projects
None yet
Milestone
No milestone
5 participants
@FrancescoBorzi @Kitzunu @T1ti @syssneck @Azcobu