-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(Core/Players): Enabled resurrecting players from opposite factio… #12012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n in crossfactioned raids. Fixes azerothcore#8600
I had the same result, selecting the portrait and casting the ress spells don't work, neither does clicking the ress spells and hovering over the body, as it won't 'highlight' the corpse and the mouse won't change to the blue icon indicating that the body is a valid target. |
|
@azerothcore/testers this needs to be tested. |
About the the insignia - it's okay. |
Can concur and validate that, this was a internal discussion the other day. |
Thank you for the PR |
…n in crossfactioned raids.
Fixes #8600
Issues Addressed:
Tests Performed:
How to Test the Changes:
be in a group with the opposite faction
try to resurrect a player from the opposing faction after he already released.
See that you can resurrect
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.