Skip to content

feat(Core/Players): Enabled resurrecting players from opposite factio… #12012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2022

Conversation

UltraNix
Copy link
Contributor

…n in crossfactioned raids.

Fixes #8600

Issues Addressed:

Tests Performed:

  • Tested ingame.

How to Test the Changes:

be in a group with the opposite faction
try to resurrect a player from the opposing faction after he already released.
See that you can resurrect

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Yehonal Yehonal added CORE Related to the core file-cpp Used to trigger the matrix build labels Jun 11, 2022
@ghost
Copy link

ghost commented Jun 12, 2022

I'm unable to reproduce this.

Test done:

  • 2 char (on human, one blood elf)
  • one char die (.die)
  • try to use res paladin spell (before and after release)

WoWScrnShot_061222_173300

WoWScrnShot_061222_173441

@Gultask
Copy link
Contributor

Gultask commented Jun 12, 2022

I had the same result, selecting the portrait and casting the ress spells don't work, neither does clicking the ress spells and hovering over the body, as it won't 'highlight' the corpse and the mouse won't change to the blue icon indicating that the body is a valid target.

@UltraNix
Copy link
Contributor Author

  1. Must be in the same party
  2. Must be hostile
  3. CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP is set to 1

@Annamaria-CC
Copy link
Member

image
We are in a group
image

@UltraNix
Copy link
Contributor Author

@Temperrr @Gultask Should be okay.

@acidmanifesto
Copy link
Contributor

@azerothcore/testers this needs to be tested.

@Gultask
Copy link
Contributor

Gultask commented Jun 18, 2022

It works but there are some bizarre texture glitches when one dies while both are in a group.

WoWScrnShot_061822_110621

WoWScrnShot_061822_110744

When both are not in a group, then the insignia icon shows up when hovering over their bodies, which I don't think should be the case? Clicking it does nothing
Sorry for the phone image:
image

@UltraNix
Copy link
Contributor Author

About the the insignia - it's okay.
About glitches - yeah. It's impossible to do it in other way- otherwise client crashes.

@acidmanifesto
Copy link
Contributor

acidmanifesto commented Jun 18, 2022

About glitches - yeah. It's impossible to do it in other way- otherwise client crashes.

Can concur and validate that, this was a internal discussion the other day.

@acidmanifesto
Copy link
Contributor

Thank you for the PR

@acidmanifesto acidmanifesto merged commit 39c0f1a into azerothcore:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChromieCraft Generic No specific levelrange CORE Related to the core file-cpp Used to trigger the matrix build To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resurrect opposite faction when already released [Cross Faction] [Spell] Resurrection of released players on opposing faction.
6 participants