Fix (Core\Script) Map Calculation Rewrite #8775

acidmanifesto · 2021-10-27T16:39:47Z

CURRENT STATUS

Only one issue left.
Blink and any front Leap spell seems to clip thru floors and bridges. Terrain ground and gameobjects is fine. Just need to figure out the going thru the floor and bridge issue now.

Purpose of this PR:
This is to address Blink, Warrior's Charge, and other vmap calculated functions that may be problematic in certain cases.

Changes Proposed:

This is to address various issues of Blink, Warrior's charge, and other vmap related calculated funcitons.

Issues Addressed:

Errornous vmap calculation handling.

Tests Performed:

Builds and compiles with no issues. Other scripts adjusted in core with this pr.

How to Test the Changes:

.cheat power on
as a priest perform the move blink spell 1953 in any and all terran variations
as a warrior perform the move Charge spell 100 in any and all terran variations

Known Issues and TODO List:

Test any variations where vmap calculations may be needed.
Test whatever quest\scenario\instance that the spell script spell_svalna_revive_champion is performed. located in northerned map.
Test Exsisting transports to ensure u can still ride from point a to point b (Horde blimps), Flight manager.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

This is to address Blink, Warrior's Charge, and other vmap calculated functions that may be problematic in certain cases.

acidmanifesto · 2021-10-27T16:40:09Z

I request the Tester's needed. We will need alot of testing before any possiblity of merging is to be considered.

src/server/game/Maps/Map.h

Nefertumm

Seems fine now

src/common/Collision/DynamicTree.cpp

Nefertumm · 2021-10-27T18:16:45Z

Build is failing

/home/runner/work/azerothcore-wotlk/azerothcore-wotlk/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp:2187:131: fatal error: implicit conversion turns floating-point number into bool: 'float' to 'bool' [-Wimplicit-conversion-floating-point-to-bool]
            pos.m_positionZ = caster->GetMap()->GetHeight(caster->GetPhaseMask(), pos.GetPositionX(), pos.GetPositionY(), caster->GetPositionZ(), true);

acidmanifesto · 2021-10-27T18:22:04Z

Build is failing

/home/runner/work/azerothcore-wotlk/azerothcore-wotlk/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp:2187:131: fatal error: implicit conversion turns floating-point number into bool: 'float' to 'bool' [-Wimplicit-conversion-floating-point-to-bool]
            pos.m_positionZ = caster->GetMap()->GetHeight(caster->GetPhaseMask(), pos.GetPositionX(), pos.GetPositionY(), caster->GetPositionZ(), true);

its gonna be one of those days with the compiling testing. im on it.

acidmanifesto · 2021-10-27T18:43:34Z

At this point i fix one thing with float to bool i end up getting another one. This is starting to extend my reach of what i want to do, and seems to be leaning towards a massive core rewrite which i just dont have the time or the patience for. I will have ask for a help wanted tag for the time being. This pr does compile and can be tested in game. However that is no excuse for failing compile testing.

mpfans · 2021-10-28T00:57:53Z

I will test this PR in two days

mpfans · 2021-10-29T06:28:31Z

Because it conflicts with one of my PR, I can't test it

acidmanifesto · 2021-10-30T15:21:15Z

ok. so extensive testing on my end. there appears to be select issues with blink allowing the priest character to mesh under GAMEOBJECTS. I suspect this is another issues dealing with the version of vmaps\mmaps we have currently on azerothcore. This PR will need to sit stagnant until we ever upgrade maps to a higher revision.

acidmanifesto · 2021-10-31T14:47:36Z

#6232

acidmanifesto · 2021-10-31T16:46:47Z

#7072

acidmanifesto · 2021-10-31T23:06:08Z

Current this is how it looks with this PR.

Show casing Warrior's charge and Blink below:

Warriors Charge:
https://youtu.be/znHdW1R_9zM

Blink with the vmap issues at the end:
https://youtu.be/lOamL5nAveU

So far only blink suffers the issues as we need to have the vmaps be in line with version 4.8

ghost · 2021-11-25T09:15:42Z

Does this need to be tested yet or is this WIP?

acidmanifesto · 2022-04-02T18:16:24Z

Current Status:
Charge does not undermesh
Blink still clips thru gameobjects and structures.

Results:
Need map improvements, which there are other PR's in progress on from other people. will test then when new maps gets deployed.

This reverts commit cef740a.

acidmanifesto · 2022-04-25T16:02:57Z

i need to retest to see if blink is still clipping thru game objects like bridges and stones, houses, whatever.
Warrior Charge is good with no issues. But if u do charge while in .gm on you will hit some weird assert error, but only when in .gm on
the thing is we only need my map.cpp and map.h adjustments.
but then we needed the collision to be linked to it via dynamic tree and because of that we ended up with errors in the creature cpp, object cpp and icecrown_citadel.cpp
so one adjust ment literally became a small cluster mess. so i have to look what i need to change in the dynamictree to fix the collison being ignored with blink
then worry about the other files crying error later such as the compile testers.

IntelligentQuantum · 2022-04-25T16:07:28Z

I ported this from TC Maybe it will help for charge idk
IntelligentQuantum@e571b09

acidmanifesto · 2022-04-25T16:25:57Z

I ported this from TC Maybe it will help for charge idk IntelligentQuantum@e571b09

i will look into that later. but there was other reasons for this pr besides charge.

acidmanifesto · 2022-04-25T21:15:18Z

CURRENT STATUS

Only one issue left.
Blink and any front Leap spell seems to clip thru floors and bridges. Terrain ground and gameobjects is fine. Just need to figure out the going thru the floor and bridge issue now.

src/server/game/Maps/Map.h

Co-authored-by: Kargatum <dowlandtop@yandex.com>

src/server/game/Maps/Map.cpp

UltraNix · 2022-05-07T10:20:54Z

src/common/Collision/DynamicTree.cpp

 {
    G3D::Vector3 v(x, y, z);
    G3D::Ray r(v, G3D::Vector3(0, 0, -1));
    DynamicTreeIntersectionCallback callback(phasemask, VMAP::ModelIgnoreFlags::Nothing);
    impl->intersectZAllignedRay(r, callback, maxSearchDist);

-    if (callback.didHit())
+    if (dCallback)


dCallback is always null, so this is completely useless.

src/server/game/Maps/Map.cpp

UltraNix · 2022-05-07T14:24:40Z

Sorry, but to me all the changes done here are nonsenses

acidmanifesto · 2022-05-07T15:04:18Z

Sorry, but to me all the changes done here are nonsenses

it stops the undermshing and been stopping all undermeshing for a while. i encourage u to try the pr and see first hand.

UltraNix · 2022-05-07T15:45:48Z

I don't need to test it - I just see the code. Map::GetHeight always returns VMAP_INVALID_HEIGHT_VALUE so broke many things.
E.g.

.gps always returns invalid ground and floor z
non-flyable mobs can fly to you (just .gm fly, ascend and .cometome to any mob
any of the gameobjects with collision (elevators, ships, etc) get wrong ground position
many spells with destination are also broken, e.g. blink, fishing
flying mobs on death gets wrong fall position
confused movement generator (e.g. blind) completely broken
and many more...

acidmanifesto · 2022-05-07T16:05:15Z

I don't need to test it - I just see the code. Map::GetHeight always returns VMAP_INVALID_HEIGHT_VALUE so broke many things. E.g.

.gps always returns invalid ground and floor z

non-flyable mobs can fly to you (just .gm fly, ascend and .cometome to any mob

any of the gameobjects with collision (elevators, ships, etc) get wrong ground position

many spells with destination are also broken, e.g. blink, fishing

flying mobs on death gets wrong fall position

confused movement generator (e.g. blind) completely broken

and many more...

if you feel like all this is happening with out testing then you are welcome to close the PR.

UltraNix · 2022-05-07T16:07:58Z

Yes - I'm pretty sure.

Map Calculation Rewrite

18e395f

This is to address Blink, Warrior's Charge, and other vmap calculated functions that may be problematic in certain cases.

github-actions bot added CORE Related to the core Script labels Oct 27, 2021

acidmanifesto changed the title ~~Map Calculation Rewrite~~ Fix (Core\Script) Map Calculation Rewrite Oct 27, 2021

Nyeriah added Waiting to be Tested Ready to be Reviewed labels Oct 27, 2021

Compile testing error fix

8d83d61

Nefertumm reviewed Oct 27, 2021

View reviewed changes

src/server/game/Maps/Map.h Outdated Show resolved Hide resolved

acidmanifesto added 3 commits October 27, 2021 13:24

Update DynamicTree.cpp

377686b

value is uninitialized fix

267b15e

added in [[nodiscard]] that was removed in error

1b12ad1

acidmanifesto requested a review from Nefertumm October 27, 2021 17:54

Nefertumm approved these changes Oct 27, 2021

View reviewed changes

Nefertumm reviewed Oct 27, 2021

View reviewed changes

src/common/Collision/DynamicTree.cpp Show resolved Hide resolved

Nyeriah added the Help Wanted label Oct 27, 2021

Merge branch 'master' into MapCalculations

bfd197f

Merge branch 'master' into MapCalculations

cddb1a0

Merge branch 'master' into MapCalculations

330d979

ghost mentioned this pull request Nov 15, 2021

Fix water blink #7812

Closed

Update icecrown_citadel.cpp

c559438

acidmanifesto added the SENSITIVE WIP SENSITIVE Work in Progress, Do not Update, Do not Merge until author approves. label Apr 2, 2022

MDIC added 3 commits April 2, 2022 13:14

Update icecrown_citadel.cpp

aa7dc94

Update icecrown_citadel.cpp

bcc120e

Update Map.h

857f288

MDIC added 3 commits April 2, 2022 14:21

Remove unused variable

cef740a

Revert "Remove unused variable"

94f4f44

This reverts commit cef740a.

Merge branch 'master' into MapCalculations

fa01a56

update

f58b421

Yehonal removed the Script label Apr 25, 2022

Update Map.cpp

b2e325e

Winfidonarleyan reviewed Apr 25, 2022

View reviewed changes

src/server/game/Maps/Map.h Outdated Show resolved Hide resolved

Winfidonarleyan reviewed Apr 25, 2022

View reviewed changes

src/server/game/Maps/Map.h Outdated Show resolved Hide resolved

acidmanifesto and others added 2 commits April 25, 2022 19:29

Update src/server/game/Maps/Map.h

8335ab1

Co-authored-by: Kargatum <dowlandtop@yandex.com>

Update src/server/game/Maps/Map.h

01aa475

Co-authored-by: Kargatum <dowlandtop@yandex.com>

UltraNix reviewed May 7, 2022

View reviewed changes

src/server/game/Maps/Map.cpp Show resolved Hide resolved

UltraNix reviewed May 7, 2022

View reviewed changes

src/server/game/Maps/Map.cpp Show resolved Hide resolved

UltraNix closed this May 7, 2022

acidmanifesto deleted the MapCalculations branch May 7, 2022 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix (Core\Script) Map Calculation Rewrite #8775

Fix (Core\Script) Map Calculation Rewrite #8775

acidmanifesto commented Oct 27, 2021 •

edited

Loading

acidmanifesto commented Oct 27, 2021

Nefertumm left a comment

Nefertumm commented Oct 27, 2021

acidmanifesto commented Oct 27, 2021

acidmanifesto commented Oct 27, 2021

mpfans commented Oct 28, 2021

mpfans commented Oct 29, 2021

acidmanifesto commented Oct 30, 2021 •

edited

Loading

acidmanifesto commented Oct 31, 2021

acidmanifesto commented Oct 31, 2021

acidmanifesto commented Oct 31, 2021

ghost commented Nov 25, 2021

acidmanifesto commented Apr 2, 2022 •

edited

Loading

acidmanifesto commented Apr 25, 2022 •

edited

Loading

IntelligentQuantum commented Apr 25, 2022

acidmanifesto commented Apr 25, 2022

acidmanifesto commented Apr 25, 2022

UltraNix May 7, 2022

UltraNix commented May 7, 2022

acidmanifesto commented May 7, 2022

UltraNix commented May 7, 2022 •

edited

Loading

acidmanifesto commented May 7, 2022

UltraNix commented May 7, 2022

Fix (Core\Script) Map Calculation Rewrite #8775

Fix (Core\Script) Map Calculation Rewrite #8775

Conversation

acidmanifesto commented Oct 27, 2021 • edited Loading

CURRENT STATUS

Changes Proposed:

Issues Addressed:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs

acidmanifesto commented Oct 27, 2021

Nefertumm left a comment

Choose a reason for hiding this comment

Nefertumm commented Oct 27, 2021

acidmanifesto commented Oct 27, 2021

acidmanifesto commented Oct 27, 2021

mpfans commented Oct 28, 2021

mpfans commented Oct 29, 2021

acidmanifesto commented Oct 30, 2021 • edited Loading

acidmanifesto commented Oct 31, 2021

acidmanifesto commented Oct 31, 2021

acidmanifesto commented Oct 31, 2021

ghost commented Nov 25, 2021

acidmanifesto commented Apr 2, 2022 • edited Loading

acidmanifesto commented Apr 25, 2022 • edited Loading

IntelligentQuantum commented Apr 25, 2022

acidmanifesto commented Apr 25, 2022

acidmanifesto commented Apr 25, 2022

CURRENT STATUS

UltraNix May 7, 2022

Choose a reason for hiding this comment

UltraNix commented May 7, 2022

acidmanifesto commented May 7, 2022

UltraNix commented May 7, 2022 • edited Loading

acidmanifesto commented May 7, 2022

UltraNix commented May 7, 2022

acidmanifesto commented Oct 27, 2021 •

edited

Loading

acidmanifesto commented Oct 30, 2021 •

edited

Loading

acidmanifesto commented Apr 2, 2022 •

edited

Loading

acidmanifesto commented Apr 25, 2022 •

edited

Loading

UltraNix commented May 7, 2022 •

edited

Loading