fix: simplify resize percentage calculations#388
Merged
Conversation
- simplify resize percentage calculations by removing redundant multiplications
MagnunAVFAzion
approved these changes
Feb 13, 2026
pablodiehl
approved these changes
Feb 13, 2026
pablodiehl
pushed a commit
that referenced
this pull request
Feb 13, 2026
Collaborator
|
🎉 This PR is included in version 1.20.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes adjustments to the image resizing logic and response handling in the
packages/wasm-image-processor/src/index.tsfile. The most significant change is a fix to the calculation of resize percentages, ensuring more accurate image resizing. Additionally, the response generation is updated to bypass TypeScript type checks for compatibility.Image resizing logic improvements:
resizefunction by removing unnecessary multiplication and division by 100, resulting in more accurate resizing. (resizeinpackages/wasm-image-processor/src/index.ts)Response handling adjustments:
@ts-ignoreto the response creation ingetImageResponseto bypass TypeScript type checks, likely to address type compatibility issues with the response object. (getImageResponseinpackages/wasm-image-processor/src/index.ts)