Standardize the repository #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - Instruction to set up development environment - Visual Studio Code settings - Pipfile: black, flake8, fake-bpy-module-2.83 - .gitignore: ignore some Python, Linux, Windows, MacOS, Blender files
- Recommended style guide is applied. Reference: https://wiki.blender.org/wiki/Style_Guide/Python - Remove the signature and license at the top of the file as they're presented in `bl_info` and LICENSE. - Change the functions name to improve reading and spelling. - Check keymaps config before unregister.
Follow this recommended format: https://github.com/olivierlacan/keep-a-changelog/blob/main/CHANGELOG.md. Also fix some minor typos.
- Replace Visual Studio Settings (folder `.vscode`) with `.editorconfig` and `.flake8` to improve flexibility between development platforms while keeping consistency of coding style. - Update development setup guide in `README.md` following new settings. - Remove `Pipfile.lock` as it has problems with package sync between different platforms. Current packages are good with only `Pipfile`.
Remove: - `*.pyc` files. - `PIL/a` file.
Collaborator
Author
|
@Yeetus3141 I would like to ask your opinion before merging this PR as it will change a lot in the repo that you've carefully built before. |
Merged
b-init
approved these changes
Jun 17, 2021
Owner
b-init
left a comment
b-init
left a comment
There was a problem hiding this comment.
Everything seems alright! And I do not have any required changes on mind for now
Collaborator
Author
|
I added some minor changes and will merge it now. Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements mainly focused on repository infrastructure for future contributions: