MockJsRuntime should have a SetupVoid() method

[egil]

To make it easier/more intuitive to mock a InvokeVoidAsync call, the MockJsRuntimeInvocationHandler should have a SetupVoid method in addition to the Setup methods.

This means there should probably also be SetCompleted method in JsRuntimePlannedInvocation, or at least a SetResult without parameters.

[Siphonophora]

Looking at this, I think multiple overloads for SetResults might be confusing if users need to pick the right overload to match the setup method they chose. What do you think about adding a non-generic planed invocation, or maybe a builder class, for setting up void methods? It might be easier for users.

[egil]

Hey @Siphonophora, thanks for engaging. I agree. There probably needs to be a relation between a SetupVoid and a non-generic version of PlannedInvocation. That could have a method named SetVoidResult just to make it very clear what is going on.

I am also debating whether to stick so close to the TaskCompletionSource naming scheme and e.g. call the methods e.g. Cancel, Throw, and Return. Currently thinking sticking with TaskCompletionSource is better, as users might be familiar with those methods already.

[Siphonophora]

@egil I just got a chance to take a look, and this looks good.

I think the naming scheme is clear. From playing with some examples, I think SetResult would be clear enough for me on the void method. But it probably is clearer for someone reading the code as SetVoidResult

[egil]

Yep. My thinking was that the symmetry with InvokeVoidAsync makes it worthwhile to have the extra characters.