Make WrapperElementsGenerator cacheable using collect-and-execute pattern #1781
+78
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WrapperElementsGeneratorwas returningIncrementalValuesProvider<ISymbol>, which isn't cacheable, causing the pipeline to trigger on every build of thebunit.webproject.Changes
Introduced cacheable record types
ElementInterfacesData: Holds immutable array of element type infoElementTypeInfo: StoresName,FullyQualifiedName, andMetadataNameas stringsImplemented collect-and-execute pattern
Selectextracts minimal type information into records during compilationCombinemerges cached data withCompilationProviderto retrieve full symbols only when neededGetTypeByMetadataName()using cached metadata namesAdded defensive checks
Before
After
The generator now caches only hashable data, enabling incremental compilation to skip regeneration when AngleSharp assembly hasn't changed.
Original prompt
WrapperElementsGeneratorcachable #1397💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.