Update to Babylon 7 (fixes #481)

[soda0289]

EDIT by @hzoo, Fixes #481

I did not add any tests. What new syntax in babylon 7 is there to test?

[hzoo]

Awesome to see that's all that's required for the tests that are there 👍

[hzoo]

I would pin the versions while we're in alpha (so ^ should be removed)

[hzoo]

https://github.com/babel/babylon#plugins

• numericSeparator: 1_0
• optionalChaining: a?.b
• importMeta: import.meta.a
• classPrivateProperties: class A { #a = 1 }
• dynamicImport: import('a').then(() => {})

Although we can just deal with it when we get issues for it as well. We may need to make changes to https://github.com/babel/eslint-plugin-babel to handle new syntax.

[soda0289]

I pinned the dependencies for babel to 7.0.0.alpha12 and babylon to 7.0.0.beta13

[hzoo]

There's a deprecation for code-frame, https://github.com/babel/babel/pull/5808/files

babel-eslint/index.js

Line 421 in 54ed517

codeFrame(code, err.lineNumber, err.column, { highlightCode: true });

[hzoo]

Also can you add https://github.com/soda0289/babel-eslint/blob/481868d404aa606946e68b6504a6f0bdf8a744d9/index.js#L385-L400 to the plugins array the new ones I mentioned above? https://github.com/babel/babylon/#plugins

I'l push it

[hzoo]

• need to handle no-undef/no-unused-vars for private properties

export class C {
  #d = 1; // error  'd' is not defined  no-undef
}

[soda0289]

@hzoo I can write some tests for those cases.

[soda0289]

Update the eslint-scope monkey patch to handle private class properties and included tests. Anything else that needs tests/updating?

[hzoo]

Just testing it on a codebase it is good until we find other errors (in theory we should just against all eslint rules but it's hard to setup)

Tried and gave up a few times to setup #62

[hzoo]

Awesome work @soda0289!!

[nodkz]

It's quite strange but optionalChaning does not work for me with babel-eslint@8.0.0-alpha.13

https://twitter.com/nodkz/status/885529331212193793

Using such .babelrc.js: https://gist.github.com/nodkz/41e189ff22325a27fe6a5ca81df2cb91
Code transpiles and executes perfectly.

Maybe I miss some tricky option?