Fatal error: assumes that the entity is a node in leaflet_views

[herbdool]

I'm just testing the module for a different error and came across this one:

TypeError: node_view(): Argument #1 ($node) must be of type Node, User given, called in /app/httpdocs/modules/leaflet/modules/leaflet_views/leaflet_views_plugin_style.inc on line 322 in node_view() (line 1115 of /app/httpdocs/core/modules/node/node.module).

It might be as simple as changing the line to be:

$build = entity_view($entity, $this->options['view_mode']);

I got this error after adding a geofield to the user account, and then adding a view to display the location and choosing <user entity> for displaying the description.

The popup appears empty so there might be a different problem as well.

[herbdool]

By the way, I also initially saw this error:

Warning: Undefined array key "view modes" in leaflet_views_plugin_style->options_form() (line 195 of /app/httpdocs/modules/leaflet/modules/leaflet_views/leaflet_views_plugin_style.inc).
Warning: foreach() argument must be of type array|object, null given in leaflet_views_plugin_style->options_form() (line 195 of /app/httpdocs/modules/leaflet/modules/leaflet_views/leaflet_views_plugin_style.inc).

which may indicate that there should be a default "view mode" available if someone has not yet saved the settings. Or add a check.

[indigoxela]

@herbdool I can reproduce the warning with a view from user accounts, but can't reproduce the type error on php 8.3.

Mind to add full steps to reproduce? More details might help to reproduce the error, especially the views settings.
I'm struggling to understand the "user entity for displaying the description" part.

[indigoxela]

Never mind, figured out, how to reproduce it. 👍

[indigoxela]

It might be as simple as changing the line to be...

Yes, it's just as simple. 😄

The warnings were caused by the way the entity type was guessed by base table, which would only work for entity types, for which the base table has the same name as the type. So there's now "improved guessing" (it's still guessing).

Happy testing with the PR.

[herbdool]

@indigoxela works for me, thanks.

[indigoxela]

Awesome, many thanks for reporting and feedback @herbdool

Merged into 1.x and 2.x and released (1.x).