Skip to content

Conversation

@alexlorenzi
Copy link
Contributor

Replace GITHUB_TOKEN with generated app token to ensure proper permissions for semantic release operations

Replace GITHUB_TOKEN with generated app token to ensure proper permissions for semantic release operations
@alexlorenzi alexlorenzi requested review from a team and awanlin as code owners September 16, 2025 15:26
@alexlorenzi
Copy link
Contributor Author

alexlorenzi commented Sep 16, 2025

Hi @nickhudkins - I created this PR based on the info you mentioned in @awanlin's issue #297.
Would you mind taking a look, if you have a spare moment? I believe I've updated the action correctly, but I'm not sure the best way to test it without actually bumping the version.
Thanks

Modified bot tokens so they're a bit more descriptive
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one thing we might want to changes

Update the generate_token action to use the create-github-app-token action
@alexlorenzi
Copy link
Contributor Author

Spotted one thing we might want to changes

Good catch. Updated 🙇

Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I look this over my thinking is: what would this break/impact? We can't release using the automation right now so if this doesn't work we aren't in a worse spot and we've perhaps learned something. I say we merge this in and try it out! 🚀

@alexlorenzi alexlorenzi merged commit 470077c into main Sep 16, 2025
7 checks passed
@alexlorenzi alexlorenzi deleted the use-app-token-for-semantic-release branch September 16, 2025 18:40
@alexlorenzi
Copy link
Contributor Author

As I look this over my thinking is: what would this break/impact? We can't release using the automation right now so if this doesn't work we aren't in a worse spot and we've perhaps learned something. I say we merge this in and try it out! 🚀

YOLO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants