-
Notifications
You must be signed in to change notification settings - Fork 77
ci: use app token for semantic release workflow #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace GITHUB_TOKEN with generated app token to ensure proper permissions for semantic release operations
|
Hi @nickhudkins - I created this PR based on the info you mentioned in @awanlin's issue #297. |
Modified bot tokens so they're a bit more descriptive
awanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted one thing we might want to changes
Update the generate_token action to use the create-github-app-token action
Good catch. Updated 🙇 |
awanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I look this over my thinking is: what would this break/impact? We can't release using the automation right now so if this doesn't work we aren't in a worse spot and we've perhaps learned something. I say we merge this in and try it out! 🚀
YOLO |
Replace GITHUB_TOKEN with generated app token to ensure proper permissions for semantic release operations