This repository was archived by the owner on Aug 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Mutate block-pass arguments #54
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 6 additions & 5 deletions
11
lib/mutest/mutator/node/noop.rb → lib/mutest/mutator/node/block_pass.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,20 @@ | ||
| module Mutest | ||
| class Mutator | ||
| class Node | ||
| # Mutation emitter to handle noop nodes | ||
| class Noop < self | ||
| handle(:block_pass, :cbase) | ||
| class BlockPass < self | ||
| handle(:block_pass) | ||
|
|
||
| children :arg | ||
|
|
||
| private | ||
|
|
||
| # Emit mutations | ||
| # | ||
| # @return [undefined] | ||
| def dispatch | ||
| # noop | ||
| emit_arg_mutations | ||
| end | ||
| end # Noop | ||
| end # BlockPass | ||
| end # Node | ||
| end # Mutator | ||
| end # Mutest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ class Node | |
| # Generic mutator | ||
| class Generic < self | ||
| unsupported_nodes = %i[ | ||
| cbase | ||
| ensure | ||
| redo | ||
| retry | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,14 @@ | ||
| Mutest::Meta::Example.add :block_pass do | ||
| source 'foo(&bar)' | ||
| source 'foo(&method(:bar))' | ||
|
|
||
| singleton_mutations | ||
| mutation 'foo' | ||
| mutation 'foo(&nil)' | ||
| mutation 'foo(&self)' | ||
| mutation 'foo(&method)' | ||
| mutation 'foo(&method(nil))' | ||
| mutation 'foo(&method(self))' | ||
| mutation 'foo(&method(:bar__mutest__))' | ||
| mutation 'foo(&public_method(:bar))' | ||
| mutation 'foo(&:bar)' | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we can avoid emitting these mutations? They are invalid.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not invalid. I had a check for them, but I tried it, and you can actually do
&nil. It's a no-op so we could choose not to do it if we wanted. We could also skip&selfbut that works for objects that define#to_procso possibly reasonable to have?.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool. Alrighty then