Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Add === -> #kind_of? mutation#9

Merged
backus merged 1 commit into
masterfrom
feature/threequals_to_kind_of_mutation
Jan 28, 2017
Merged

Add === -> #kind_of? mutation#9
backus merged 1 commit into
masterfrom
feature/threequals_to_kind_of_mutation

Conversation

@dgollahon
Copy link
Copy Markdown
Owner

@dgollahon dgollahon force-pushed the feature/threequals_to_kind_of_mutation branch 3 times, most recently from ce954b9 to 5550813 Compare January 28, 2017 09:59
Comment thread meta/send.rb Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just add === to the right side of the - above

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I guess that makes sense.

@dgollahon dgollahon force-pushed the feature/threequals_to_kind_of_mutation branch 2 times, most recently from 175ca70 to 1e61f05 Compare January 28, 2017 10:33
@dgollahon
Copy link
Copy Markdown
Owner Author

I wonder if we should also directly emit a mutation to instance_of? instead of waiting for it to happen via a second mutest run. See mbj/mutant#431 for some discussion on the general topic.

Pro: less effort for user if there is an alive.
Con: We generate more mutations than necessary (and I think the case where an instance_of? alive is probably rare v.s. === operators being relatively common).

Thoughts?

- Also sorts the SELECTOR_REPLACEMENTS list.
@backus backus force-pushed the feature/threequals_to_kind_of_mutation branch from 1e61f05 to 33eecb6 Compare January 28, 2017 22:24
@backus
Copy link
Copy Markdown
Collaborator

backus commented Jan 28, 2017

I wonder if we should also directly emit a mutation to instance_of? instead of waiting for it to happen via a second mutest run. See mbj/mutant#431 for some discussion on the general topic.

From discussion in slack, I like these sorts of optimizations but I think we need to wait until we can implement more sophisticated probing

Copy link
Copy Markdown
Collaborator

@backus backus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@backus backus merged commit c838fda into master Jan 28, 2017
@backus backus deleted the feature/threequals_to_kind_of_mutation branch January 28, 2017 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants