Skip to content

Conversation

@raimohanska
Copy link
Contributor

Same as #707 but merged onto the 2.0 branch

@raimohanska raimohanska changed the base branch from master to 2.0 January 22, 2018 17:06
@raimohanska raimohanska mentioned this pull request Jan 22, 2018
@raimohanska
Copy link
Contributor Author

Needs fix:

  • Current dist/Bacon.js doesn't work in browsers as-is: ReferenceError: global is not defined

Optional improvements that are not blockers in my opinion:

  • Testing custom builds is broken. It used to be so that you can say test map and you'll get a build that only contains map and then tests for map are run. I don't see this as a blocker though.
  • Get rid of grunt, build, test and run-tests scripts, use package.json scripts instead
  • Move all scripts that are still necessary under scripts directory to cleanup the root

@raimohanska
Copy link
Contributor Author

Fixed the global is not defined problem.

@raimohanska
Copy link
Contributor Author

Current status:

  • Testing custom builds is broken. It used to be so that you can say test map and you'll get a build that only contains map and then tests for map are run. I don't see this as a blocker though.

@raimohanska raimohanska merged commit faa293e into 2.0 Jan 25, 2018
@raimohanska raimohanska mentioned this pull request Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants