Skip to content

cache matrix badges for 4 hours#10778

Merged
chris48s merged 1 commit intobadges:masterfrom
chris48s:10776-matrix-cache
Jan 1, 2025
Merged

cache matrix badges for 4 hours#10778
chris48s merged 1 commit intobadges:masterfrom
chris48s:10776-matrix-cache

Conversation

@chris48s
Copy link
Member

Refs #10776

This isn't a fix, but one of the things that came up in that issue is we should be caching this for a lot longer. The current cacheLength of 30 seconds is likely a copy & paste from elsewhere rather than a sensible value for this badge.

@chris48s chris48s added the service-badge New or updated service badge label Dec 31, 2024
@github-actions
Copy link
Contributor

Warnings
⚠️ This PR modified service code for matrix but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 67de940

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good first step!

@chris48s chris48s added this pull request to the merge queue Jan 1, 2025
Merged via the queue into badges:master with commit 3daef19 Jan 1, 2025
@chris48s chris48s deleted the 10776-matrix-cache branch January 1, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-badge New or updated service badge

Development

Successfully merging this pull request may close these issues.

2 participants