Skip to content

Fixed add column with decimal type #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fixed add column with decimal type #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions mysql_ch_replicator/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,6 @@ def __convert_alter_table_add_column(self, db_name, table_name, tokens):
if len(tokens) < 2:
raise Exception('wrong tokens count', tokens)

if ',' in ' '.join(tokens):
raise Exception('add multiple columns not implemented', tokens)

column_after = None
column_first = False
if tokens[-2].lower() == 'after':
Expand Down Expand Up @@ -522,9 +519,6 @@ def __convert_alter_table_add_column(self, db_name, table_name, tokens):
self.db_replicator.clickhouse_api.execute_command(query)

def __convert_alter_table_drop_column(self, db_name, table_name, tokens):
if ',' in ' '.join(tokens):
raise Exception('add multiple columns not implemented', tokens)

if len(tokens) != 1:
raise Exception('wrong tokens count', tokens)

Expand All @@ -547,9 +541,6 @@ def __convert_alter_table_modify_column(self, db_name, table_name, tokens):
if len(tokens) < 2:
raise Exception('wrong tokens count', tokens)

if ',' in ' '.join(tokens):
raise Exception('add multiple columns not implemented', tokens)

column_name = strip_sql_name(tokens[0])
column_type_mysql = tokens[1]
column_type_mysql_parameters = ' '.join(tokens[2:])
Expand Down Expand Up @@ -578,9 +569,6 @@ def __convert_alter_table_change_column(self, db_name, table_name, tokens):
if len(tokens) < 3:
raise Exception('wrong tokens count', tokens)

if ',' in ' '.join(tokens):
raise Exception('add multiple columns not implemented', tokens)

column_name = strip_sql_name(tokens[0])
new_column_name = strip_sql_name(tokens[1])
column_type_mysql = tokens[2]
Expand Down
4 changes: 3 additions & 1 deletion test_mysql_ch_replicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ def test_e2e_regular(config_file):


mysql.execute(f"ALTER TABLE `{TEST_TABLE_NAME}` ADD `last_name` varchar(255); ")
mysql.execute(f"INSERT INTO `{TEST_TABLE_NAME}` (name, age, last_name) VALUES ('Mary', 24, 'Smith');", commit=True)
mysql.execute(f"ALTER TABLE `{TEST_TABLE_NAME}` ADD `price` decimal(10,2) DEFAULT NULL; ")

mysql.execute(f"INSERT INTO `{TEST_TABLE_NAME}` (name, age, last_name, price) VALUES ('Mary', 24, 'Smith', 3.2);", commit=True)

assert_wait(lambda: len(ch.select(TEST_TABLE_NAME)) == 4)
assert_wait(lambda: ch.select(TEST_TABLE_NAME, where="name='Mary'")[0]['last_name'] == 'Smith')
Expand Down