Detect missing database and recreate & Fix enum conversion uppercase to lowercase etc. #121
Conversation
| # ensure target database still exists | ||
| if self.target_database not in self.clickhouse_api.get_databases(): | ||
| logger.warning(f'database {self.target_database} missing in CH') | ||
| if self.initial_only: |
There was a problem hiding this comment.
We could not remove this check.
We could start replication, and then interrupt until it finished and then continue. It will start from zero instead of trying to continue.
We should probably check for both target_database and target_database_tmp missing, and only in this case we are good to go with restarting.
There was a problem hiding this comment.
Okay i modified it, what do you think now?
My only problem with it is that on boot if the database was not there, it would just continue as if it was 🤷🏿
I'm also available to do a call as well if needed. I'm on discord at: @jaredmdobson
|
Thanks for the PR! Looks good (especially enum handling)! Left few comments about some unsafe changes, probably the easiest solution is to address them in a separate PR with additional tests (and for this PR only leave enum related changes). |
…to lowercase etc. (bakwc#121)
2 participants
No description provided.