Skip to content

Conversation

@Deniskore
Copy link
Collaborator

@Deniskore Deniskore commented Oct 31, 2024

This pull request enhances compilation settings via CMake by:

  1. Introducing an option, USE_MARCH_NATIVE, for compiling specifically for the native PC architecture.
  2. Setting Skylake (2015) as the default march for x86_64.
  3. Activating Link Time Optimization (LTO) if it is supported.
  4. The minimum supported CMake version for CXX 23 is 3.20.

@Deniskore Deniskore requested a review from bakwc October 31, 2024 08:52
@Deniskore
Copy link
Collaborator Author

Merge only if the JSON tests pass 🙏🏼

@Deniskore Deniskore force-pushed the improve_compile_options branch from ff1d36f to b2fad5b Compare October 31, 2024 09:05
@Deniskore Deniskore force-pushed the improve_compile_options branch from b2fad5b to a53aef3 Compare October 31, 2024 10:08
@bakwc bakwc merged commit c7f92d9 into master Oct 31, 2024
1 check passed
@Deniskore Deniskore deleted the improve_compile_options branch October 31, 2024 10:55
jaredmdobson pushed a commit to ReMatter/mysql_ch_replicator that referenced this pull request Nov 5, 2025
* Improve compile options

* Updated binaries

---------

Co-authored-by: Filipp Ozinov <filipp@bakanov.su>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants