Fix CREATE TABLE parsing with multiple spaces #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle multiple consecutive spaces in field definitions - Add test case to reproduce issue #160 - Fixes 'unknown mysql type' error during realtime replication
jaredmdobson
pushed a commit
to ReMatter/mysql_ch_replicator
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Problem: Replication was failing with "unknown mysql type" when CREATE TABLE had multiple spaces between column name and type.
Changes:
split()instead ofsplit(' ')to handle multiple spaces properlyThe issue happened because
split(' ')creates empty strings with multiple spaces, making the parser extract empty field types instead of the actual type like "bigint".