Fix create drop table if exists #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good, for the future it's worth adding some unit-tests / modifying existing tests so they start checking this case too. |
jaredmdobson
pushed a commit
to ReMatter/mysql_ch_replicator
that referenced
this pull request
Nov 5, 2025
* Fix "DROP TABLE IF EXISTS" * Fix "CREATE TABLE IF NOT EXISTS"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
CREATE TABLE IF NOT EXISTSalready worked if the table didn't exist, but still tried to create it a second time if it did, so I passed it on from mysql_structure to clickhouse_structure and modified theCREATEstatementDROP TABLE IF EXISTSdidn't work for similar reasons. I tried to follow the pattern forCREATEto fix this.If you prefer an issue to be opened for fixes like this, then let me know and I'll open one