Add support for "ALTER TABLE t COLUMN c INT FIRST", and fix bug when primary key columns move. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primary key columns move. Id columns always move when adding a first column, but they could also move when adding a column using AFTER, or when dropping a column if the primary key isn't the first column. Probably a rare case, but the result if it happens would be that the column order in the internal state doesn't match the database anymore, which is bad.
nielsreijers
force-pushed
the
support-alter-column-add-first
branch
from
f34b00e to
99b15b7
Compare
jaredmdobson
pushed a commit
to ReMatter/mysql_ch_replicator
that referenced
this pull request
Nov 5, 2025
…primary key columns move. (bakwc#79) Id columns always move when adding a first column, but they could also move when adding a column using AFTER, or when dropping a column if the primary key isn't the first column. Probably a rare case, but the result if it happens would be that the column order in the internal state doesn't match the database anymore, which is bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Id columns always move when adding a first column, but they could also move when adding a column using AFTER, or when dropping a column if the primary key isn't the first column.
Probably a rare case, but the result if it happens would be that the column order in the internal state doesn't match the database anymore, which is bad since newly inserted data ends up in the wrong columns.