Add LIMIT_IN and LIMIT_OUT for joinswap/exitswap #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemcdonald
requested changes
Feb 2, 2020
Collaborator
mikemcdonald
left a comment
mikemcdonald
left a comment
There was a problem hiding this comment.
The exitswapPoolAmountIn test in math_extreme_weights fails with the new enforced ratios. Can you update that and re-push?
Collaborator
Author
|
Sure, will work on it today or tomorrow 👍
…On Sun, Feb 2, 2020, 10:17 Mike McDonald ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The exitswapPoolAmountIn test in math_extreme_weights fails with the new
enforced ratios. Can you update that and re-push?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#214>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM72WSF7PSCXTKI3FLR7N3RA3P2PANCNFSM4KMGSOGQ>
.
|
…use it tries to withdraw above 33% limit.
mikemcdonald
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the same limits for joinswap and exitswap as the pure swap functions