Skip to content

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Jul 26, 2020

@coveralls
Copy link

coveralls commented Jul 26, 2020

Pull Request Test Coverage Report for Build 184656483

  • 98 of 103 (95.15%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 11 16 68.75%
Totals Coverage Status
Change from base Build 175941714: 0.06%
Covered Lines: 4259
Relevant Lines: 4645

💛 - Coveralls

@Dandandan Dandandan changed the title Support create or replace table Support create or replace view/table Jul 26, 2020
@Dandandan Dandandan force-pushed the create_or_replace branch from e53b3be to 14aa266 Compare July 27, 2020 17:40
@nickolay
Copy link
Contributor

I've already "approved" this in GitHub UI earlier, but to confirm: this looks great to me!

@Dandandan Dandandan merged commit d2e4340 into main Jul 27, 2020
@Dandandan
Copy link
Contributor Author

Awesome @nickolay ! Thanks for the review

@alamb alamb deleted the create_or_replace branch February 5, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants