Implement parsing of Postgres regex match operators#307
Closed
returnString wants to merge 1 commit into
Closed
Conversation
Pull Request Test Coverage Report for Build 749129485
💛 - Coveralls |
Contributor
|
I think this is looking good @returnString . Can you fix or ignore the linting errors? |
Contributor
|
Possibly made redundant by #328 |
Contributor
|
Closing this PR as #328 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
This PR adds support for parsing Postgres' POSIX regex matching operators. These are similar in nature to
LIKEet al but with full support for regex patterns rather than being restricted to wildcards, so you can useselect * from my_table where name ~ '^pattern$'.I've restricted the parsing to only run when using the Postgres dialect, but I've not given lexing the same treatment as that doesn't seem to be the done thing (e.g.
PGBitwiseXoris lexed unconditionally). If this is actually desired, please let me know!I'm not entirely happy with the token names, but given the overlap (e.g.
~is both a unary and bitwise op now) I didn't want to attach names that were overly specific either.