Skip to content

Conversation

@brainexe
Copy link
Contributor

there no BC visible to me :)

@Jeroeny
Copy link

Jeroeny commented Nov 26, 2020

Anything holding back this merge? :)

@ktomk
Copy link
Collaborator

ktomk commented Dec 23, 2020

On Travis-CI there is yet no full support for php: 8.0 - which is why this PR build still appears currently red to me - , PHP 8 support could work by nightly/8.0snapshot and/or using the standard Linux OS/dist (Xenial).

So for this PR if I may suggest: add an allow_failures job for php: 8.0 (the recently added one; and keep everything else).

jobs:
  fast_finish: true
  allow_failures:
    - php: '8.0' # php 8.0 missing on travis <https://travis-ci.community/t/php-8-0-missing/10132>

And then test again without specifying trusty - if green, remove the allowed failure. See as well the link in the example above.

@Jeroeny Jeroeny mentioned this pull request Jan 18, 2021
@ktomk ktomk mentioned this pull request Feb 21, 2021
@ktomk ktomk closed this in #64 Feb 21, 2021
@ktomk
Copy link
Collaborator

ktomk commented Feb 21, 2021

@brainexe Thanks for taken care, I cherry picked the applicable changes in a different PR and closed this one. Thanks as well @Jeroeny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants