Skip to content

fix(getInputs): Fix getInputs for <Text> children #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2018
Merged

fix(getInputs): Fix getInputs for <Text> children #15

merged 2 commits into from
Apr 11, 2018

Conversation

@gh-clement-taboulot
Copy link
Contributor

@gh-clement-taboulot gh-clement-taboulot commented Apr 11, 2018

No description provided.

tpucci
tpucci reviewed Apr 11, 2018
View reviewed changes
src/withNextInputAutoFocus.js Outdated
(isArray(children) ? children : [children]).reduce((partialInputs, child) => {
if (child.props.children) {
if (child.props && child.props.children) {
debugger;
Copy link
Contributor

@tpucci tpucci Apr 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

@coveralls
Copy link

coveralls commented Apr 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 55

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 54.589%
Totals Coverage Status
Change from base Build 51: 0.7%
Covered Lines: 83
Relevant Lines: 133
💛 - Coveralls

@gh-clement-taboulot gh-clement-taboulot merged commit a22c534 into master Apr 11, 2018
@gh-clement-taboulot gh-clement-taboulot deleted the taboulot-patch-1 branch April 11, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tpucci tpucci tpucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gh-clement-taboulot @coveralls @tpucci