Bottom form #17
Merged
Bottom form #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almouro
suggested changes
May 10, 2018
Contributor
Almouro
left a comment
Almouro
left a comment
There was a problem hiding this comment.
Awesome! Just small syntax comments, thanks for the PR!
README.md
Outdated
| /> | ||
| ); | ||
|
|
||
| name="gender" |
Contributor
There was a problem hiding this comment.
I don't think this should be here :D
README.md
Outdated
| ); | ||
| ``` | ||
|
|
||
| ## Troubleshooting |
README.md
Outdated
|
|
||
| ## Troubleshooting | ||
|
|
||
| ### Create a form at the bottom of a page |
Contributor
There was a problem hiding this comment.
I would rename to "Move form above keyboard"
README.md
Outdated
|
|
||
| ### Create a form at the bottom of a page | ||
|
|
||
| The purpose of this section is to give you a solution to create a bottom form which will go up when the keyboard appear, and the content at the top at the page will disappear. |
README.md
Outdated
|
|
||
| The purpose of this section is to give you a solution to create a bottom form which will go up when the keyboard appear, and the content at the top at the page will disappear. | ||
|
|
||
| You have to : |
README.md
Outdated
|
|
||
| You have to : | ||
|
|
||
| * Create a form like you learn before ; |
Contributor
Author
There was a problem hiding this comment.
It's more "like you learnt above"
README.md
Outdated
| You have to : | ||
|
|
||
| * Create a form like you learn before ; | ||
| * Use [react-native-keyboard-spacer](https://github.com/Andr3wHur5t/react-native-keyboard-spacer) : it will create view with the keyboard's size when the keyboard will opened; |
README.md
Outdated
|
|
||
| * Create a form like you learn before ; | ||
| * Use [react-native-keyboard-spacer](https://github.com/Andr3wHur5t/react-native-keyboard-spacer) : it will create view with the keyboard's size when the keyboard will opened; | ||
| * Use [react-native-hide-with-keyboard](https://github.com/bamlab/react-native-hide-with-keyboard) : it will hide component when the keyboard will opened. |
|
|
||
| Enjoy your life : | ||
|
|
||
|  |
| export default AdoptACat; | ||
| ``` | ||
|
|
||
| For Android, we don't have to use react-native-keyboard-spacer because `android:windowSoftInputMode` is in `adjustResize` mode. Indeed, the view is automatically resize and you don't have to fill it like on iOS. |
Review's changes
Almouro
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New section that explain how to create a bottom form.