Skip to content

chore: add formik as peer dependency #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2018
Merged

chore: add formik as peer dependency #23

merged 2 commits into from
Jun 27, 2018

Conversation

@pierpo
Copy link
Member

@pierpo pierpo commented May 31, 2018 •
edited
Loading

It feels a little weird to add yarn add formik@0.11.11 in the docs with such a specific version but I don't know any other way to add the latest 0.11 sub-version automatically...

I tried yarn add formik@0.11 but it writes "formik": "0.11" in the package.json!

@pierpo pierpo requested a review from tpucci May 31, 2018 07:50
@pierpo pierpo changed the title chore: add fornik as peer dependency chore: add formik as peer dependency May 31, 2018
@pierpo pierpo force-pushed the chore/add-formik-as-peer-dep branch from 549f513 to 05095c7 Compare May 31, 2018 07:51
@coveralls
Copy link

coveralls commented May 31, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 85

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.714%
Totals Coverage Status
Change from base Build 72: 0.0%
Covered Lines: 85
Relevant Lines: 134
💛 - Coveralls

@pierpo pierpo force-pushed the chore/add-formik-as-peer-dep branch from d816ceb to 2aa7a10 Compare May 31, 2018 08:19
@pierpo pierpo requested a review from Almouro May 31, 2018 08:25
@pierpo pierpo force-pushed the chore/add-formik-as-peer-dep branch from 2aa7a10 to 315ef1c Compare May 31, 2018 08:28
@leesiongchan
Copy link

leesiongchan commented Jun 3, 2018

Can we make support for 1.0.0-beta as well?

@pierpo
Copy link
Member Author

pierpo commented Jun 4, 2018

Well, anything is possible!

Have you tried react-native-formik with formik v1.0.0-beta?

@Almouro
Copy link
Contributor

Almouro commented Jun 21, 2018

@leesiongchan @pierpo yes it works with v1 of formik. @pierpo can you add that to the peer dependencies and the doc? :)

@Almouro Almouro force-pushed the chore/add-formik-as-peer-dep branch from 315ef1c to d1d015f Compare June 27, 2018 12:15
@Almouro Almouro merged commit da1108d into master Jun 27, 2018
@Almouro Almouro deleted the chore/add-formik-as-peer-dep branch June 27, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpucci tpucci Awaiting requested review from tpucci

@Almouro Almouro Awaiting requested review from Almouro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierpo @coveralls @leesiongchan @Almouro