Skip to content

Conversation

@akunbeben
Copy link
Contributor

Based on my explanation here #1435. This is to support Livewire v3 release.

To keep it backward compatible with the previous version of Livewire, I keep the old listener.

Here I created a new listener based on the old listener:
I removed the $data['view'] due to in the Livewire 3 is now we don't really need to have a view.
Then, $component->getPublicPropertiesDefinedBySubClass() is now moved to the Livewire\Concerns\InteractsWithProperties::all. So, $component->all()

I updated the Barryvdh\Debugbar\LaravelDebugbar::isJsonRequest to only check the header key instead of its value. Because the Livewire v3 x-livewire header is an empty string "", as you know it could be a falsy value

@barryvdh barryvdh merged commit 56a2dc1 into barryvdh:master Jul 26, 2023
@akunbeben akunbeben deleted the livewire-collector-patch branch July 26, 2023 08:51
@akunbeben
Copy link
Contributor Author

Thanks, @barryvdh! Do you mind it to share when it will be released?

@DanielSpravtsev
Copy link

@barryvdh Any news about tagging new release? 🤠

@barryvdh
Copy link
Owner

barryvdh commented Aug 1, 2023

So the listen doesn't cause problems with livewire v2?

@akunbeben
Copy link
Contributor Author

Manually tested, yes it does not.

@akunbeben
Copy link
Contributor Author

If we use livewire v2, it will not reach the render. Same as v3, it will not reach the view:render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants