Skip to content

Conversation

@xenoliss
Copy link
Contributor

EIP-712 Signature Support for MCM Solana Program

This PR adds support for EIP-712 signatures on Solana using the exiting eip712sign tool. It updates the MCM program patch (invoke_signed.patch is now cb.patch) to replace the old EIP-191 message signing with EIP-712 typed structured data hashing.

EIP-712 Structure

Domain Separator

EIP712Domain(string name, string version, uint256 chainId, address verifyingContract, bytes32 salt)

Values:

  • name: "ManyChainMultiSig"
  • version: "1"
  • chainId: Solana chain identifier (e.g., 5190648258797659666 for localnet)
  • verifyingContract: address(0) (0x0000000000000000000000000000000000000000)
  • salt: MCM Program ID (32 bytes)

Message Structure

RootValidation(bytes32 root, uint32 validUntil)

Fields:

  • root: Merkle root of operations (bytes32)
  • validUntil: Expiration timestamp (uint32)

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 21, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

@cb-heimdall
Copy link
Collaborator

Review Error for josephdara-cb @ 2025-10-21 13:56:37 UTC
User must have write permissions to review

@xenoliss xenoliss requested a review from jackchuma October 21, 2025 15:57
@xenoliss xenoliss merged commit e33e740 into main Oct 21, 2025
4 checks passed
@xenoliss xenoliss deleted the bo/solana-eip712 branch October 21, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants