chore(solana): split patches, fix make command and generate mcm upgrade proposal #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
mdehoog
previously approved these changes
Oct 22, 2025
jackchuma
reviewed
Oct 22, 2025
jackchuma
reviewed
Oct 22, 2025
jackchuma
reviewed
Oct 22, 2025
cb-heimdall
dismissed
mdehoog’s stale review
Approved review 3364920217 from mdehoog is now dismissed due to new commit. Re-request for approval.
jackchuma
reviewed
Oct 22, 2025
| cargo install --git https://github.com/coral-xyz/anchor --tag v$(ANCHOR_VERSION) anchor-cli --force | ||
|
|
||
| .PHONY: deps | ||
| deps: install-rust install-solana-cli install-anchor |
Contributor
There was a problem hiding this comment.
Should we name this something else so signers don't have to comment it out before running "make deps" ?
leopoldjoy
reviewed
Oct 22, 2025
| Set the following in `.env`: | ||
|
|
||
| ```bash | ||
| MCM_PROGRAM_ID=<mcm-program-id> |
Contributor
There was a problem hiding this comment.
Don't many of these already exist? (I mean from the .env file that's defined above.)
|
|
||
| ```bash | ||
| PROGRAM=<program-address> | ||
| PROGRAM_BINARY=<path-to-.so-file> |
Contributor
There was a problem hiding this comment.
Can we pre-set these also?
| Once you have all required signatures, update `.env`: | ||
|
|
||
| ```bash | ||
| MCM_SIGNATURES_COUNT=<number-of-signatures> |
Contributor
There was a problem hiding this comment.
Suggested change
| MCM_SIGNATURES_COUNT=<number-of-signatures> | |
| MCM_SIGNATURES_COUNT=3 |
jackchuma
approved these changes
Oct 22, 2025
leopoldjoy
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-10-20-deploy-mcmtask by splitting themverifyingContractfield of the EIP712 domain separator