template for gas & elasticity increase #491
Open
+331
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
…easeGasLimit.s.sol
…e in root README.md
leopoldjoy
changed the title
jackchuma
reviewed
Nov 12, 2025
setup-templates/template-gas-and-elasticity-increase/FACILITATOR.md
Outdated
Show resolved
Hide resolved
| DENOMINATOR = ISystemConfig(SYSTEM_CONFIG).eip1559Denominator(); | ||
| } | ||
|
|
||
| function setUp() external view { |
Contributor
There was a problem hiding this comment.
I don't think this works as expected when simulating the rollback transaction. I'd remove the setUp function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a template for a combined gas & elasticity increase and is also compatible with the new Signer Tool.
NOTE: This PR remains WIP until the Signer Tool can support directly adding a config parameter that contains the full command to be run. This is because simulating rollbacks requires reversal of the environment variables which currently isn't possible (e.g. via the Makefile).