feat(sepolia-alpha): add task to transfer SystemConfig ownership to Safe #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This task transfers the SystemConfig contract ownership to the Gnosis Safe (0x0fe884546476dDd290eC46318785046ef68a0BA9). Context: - The previous task (2025-04-08-transfer-proxy-admin-ownership-to-safe) only transferred the ProxyAdmin ownership, which controls proxy upgrades - SystemConfig has a separate owner() that controls SystemConfig parameters - This task correctly transfers the SystemConfig ownership to the Safe The current SystemConfig owner is an EOA (0xAf6E0E871f38c7B653700F7CbAEDafaa2784D430) which is not compatible with the superchain-ops upgrade process.
Add comment to VALIDATION.md explaining that it was created manually rather than auto-generated by state-diff, since this is a simple EOA transaction (not a MultisigScript with EIP-712 signatures).
Collaborator
✅ Heimdall Review Status
|
jackchuma
reviewed
Nov 5, 2025
sepolia-alpha/2025-11-03-transfer-systemconfig-ownership-to-safe/.env
Outdated
Show resolved
Hide resolved
sepolia-alpha/2025-11-03-transfer-systemconfig-ownership-to-safe/.env
Outdated
Show resolved
Hide resolved
jackchuma
previously approved these changes
Nov 5, 2025
jackchuma
reviewed
Nov 5, 2025
sepolia-alpha/2025-11-03-transfer-systemconfig-ownership-to-safe/VALIDATION.md
Outdated
Show resolved
Hide resolved
…latest base/contracts Update OP_COMMIT to op-contracts/v1.8.0 final release (2073f405) and BASE_CONTRACTS_COMMIT to latest (dcd8c98a) for the SystemConfig ownership transfer task.
- Correct storage slot from 0 to 51 (0x33) for SystemConfig owner - Add explanation of OpenZeppelin upgradeable contract storage layout - Include forge inspect and cast storage commands for verification - Clarify distinction between parameter owner and upgrade admin ownership
cb-heimdall
dismissed
jackchuma’s stale review
Approved review 3422189730 from jackchuma is now dismissed due to new commit. Re-request for approval.
jackchuma
previously approved these changes
Nov 11, 2025
xenoliss
previously approved these changes
Nov 12, 2025
leopoldjoy
reviewed
Nov 12, 2025
...025-11-03-transfer-systemconfig-ownership-to-safe/script/TransferSystemConfigOwnership.s.sol
Outdated
Show resolved
Hide resolved
cb-heimdall
dismissed stale reviews from jackchuma and xenoliss
Approved review 3447950096 from jackchuma is now dismissed due to new commit. Re-request for approval.
xenoliss
approved these changes
Nov 12, 2025
jackchuma
approved these changes
Nov 13, 2025
jackchuma
deleted the
feat/sepolia-alpha-transfer-systemconfig-ownership
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task transfers the SystemConfig contract ownership to the Gnosis Safe
(0x0fe884546476dDd290eC46318785046ef68a0BA9).
Context:
transferred the ProxyAdmin ownership, which controls proxy upgrades
The current SystemConfig owner is an EOA (0xAf6E0E871f38c7B653700F7CbAEDafaa2784D430)
which is not compatible with the superchain-ops upgrade process.
Claude wrote most of this after running
make setup-task network=sepolia-alpha task=transfer-systemconfig-ownership-to-safe.