-
Notifications
You must be signed in to change notification settings - Fork 318
feat(CHAIN-2508): set up update gas params task #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
🟡 Heimdall Review Status
|
mainnet/2025-11-10-increase-gas-and-elasticity-limit/script/UpdateGasParams.s.sol
Show resolved
Hide resolved
mainnet/2025-11-10-increase-gas-and-elasticity-limit/script/UpdateGasParams.s.sol
Show resolved
Hide resolved
mainnet/2025-11-10-increase-gas-and-elasticity-limit/validations/base-signer-rollback.json
Outdated
Show resolved
Hide resolved
mainnet/2025-11-10-increase-gas-and-elasticity-limit/script/UpdateGasParams.s.sol
Show resolved
Hide resolved
| ELASTICITY = uint32(vm.envUint("FROM_ELASTICITY")); | ||
| NEW_ELASTICITY = uint32(vm.envUint("TO_ELASTICITY")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the state overrides are set (as in my suggestion below), then these pre-checks can be included (from here):
| function setUp() external view { | |
| vm.assertEq(ISystemConfig(SYSTEM_CONFIG).eip1559Denominator(), DENOMINATOR, "Denominator mismatch"); | |
| vm.assertEq(ISystemConfig(SYSTEM_CONFIG).eip1559Elasticity(), ELASTICITY, "Elasticity mismatch"); | |
| vm.assertEq(ISystemConfig(SYSTEM_CONFIG).gasLimit(), GAS_LIMIT, "Gas Limit mismatch"); | |
| } | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think the precheck doesn't work even with the overrides set. I noticed our usual gas limit script doesn't include the precheck either. I'm fine excluding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What issue did you encounter with the precheck? It works for me locally with the overrides set.
I don't mind either way, whichever you prefer!
Approved review 3445054470 from xenoliss is now dismissed due to new commit. Re-request for approval.
|
LGTM |
No description provided.