Notification doc update #547
Conversation
✅ Heimdall Review Status
|
dylsteck
left a comment
dylsteck
left a comment
There was a problem hiding this comment.
Left a non-blocking comment but otherwise LGTM
docs/onchainkit/latest/components/minikit/hooks/useNotification.mdx
Outdated
Show resolved
Hide resolved
cb-heimdall
dismissed
dylsteck’s stale review
Approved review 3367372432 from dylsteck is now dismissed due to new commit. Re-request for approval.
| "event": "notifications_disabled" | ||
| } | ||
| ``` | ||
| ## Client App Behavior |
There was a problem hiding this comment.
Let's move this to the top under Overview
There was a problem hiding this comment.
Farcaster app: Activates notification tokens immediately without waiting for a webhook success response.
Base app: Waits for a successful webhook response before activating tokens.
There was a problem hiding this comment.
Then let's turn the last paragraph into a <Note> saying: If your webhook performs token saving and notification sending before returning a response, tokens may work on Farcaster but fail to activate on Base.
|
|
||
| Different client apps handle webhook responses differently: | ||
|
|
||
| Farcaster app: Activates notification tokens immediately without waiting for a webhook success response. |
There was a problem hiding this comment.
let's add the bold back to each of these Farcaster App and Base App
|
|
||
| Different client apps handle webhook responses differently: | ||
|
|
||
| Farcaster app: Activates notification tokens immediately without waiting for a webhook success response. |
What changed? Why?
--Added timeout call out for notification
-- added depreciated warning for addMiniApp hook